USHIFT-6857: CI implementation: Support MicroShift V5.0 on RHEL 10.2 GA Implementation - #7140
Conversation
|
@agullon: This pull request references USHIFT-7285 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. This pull request references USHIFT-7286 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. This pull request references USHIFT-7287 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
approved
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughChangesBootc scenarios now validate LVMS workloads across EL 9.8 or EL 10.2 to EL 10.2 upgrades. An EL10.2 RPM-standard scenario and release-specific bootc image templates were added. Release-scenario concurrency changed from 20 to 16 jobs. Release validation coverage
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The EL9 and EL10 bootc release image templates consistently install the intended release-specific packages and preserve required service and firewall setup. No current merge-readiness risk is identified. Sequence Diagram(s)sequenceDiagram
participant ScenarioRunner
participant UpgradeVM
participant MicroShift
participant LVMS
ScenarioRunner->>UpgradeVM: Launch source-image VM
UpgradeVM->>MicroShift: Wait for readiness
ScenarioRunner->>MicroShift: Configure oc and kubeconfig
MicroShift->>LVMS: Create and validate workloads
ScenarioRunner->>UpgradeVM: Run bootc upgrade
MicroShift->>LVMS: Verify workloads and resources
ScenarioRunner->>LVMS: Clean up workloads
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 warning)
✅ Passed checks (13 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 5 files. (3 skipped: 3 unsupported.) Full details: No-Sensitive-Data-In-LogsExplanation The new scenarios activate a credential leak in CI logs. Each added Resolution Prevent secret values from reaching traced command arguments. Disable xtrace around kickstart generation or replace the pull-secret placeholder through a protected file or stdin. Remove or redact ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
test/scenarios-bootc/el10/releases/el102-y1@el102-lrel@lvms-standard1.sh (1)
1-1: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winChange the shebangs, but do not add local shell options.
test/bin/scenario.shenablesset -euo pipefailbefore sourcing these files. Update all four first lines to#!/usr/bin/bash.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/scenarios-bootc/el10/releases/el102-y1`@el102-lrel@lvms-standard1.sh at line 1, Update the shebang on line 1 of all four specified release scenario files to use /usr/bin/bash, and do not add local shell options because test/bin/scenario.sh already enables them.Sources: Coding guidelines, Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/scenarios-bootc/el10/releases/el102`@rpm-lvms-standard.sh:
- Line 1: Update the shebang at the top of the script from /bin/bash to
/usr/bin/bash, leaving the rest of the script unchanged.
- Line 46: Update the script header to use /usr/bin/bash and enable set -euo
pipefail. In the declaration around reponame, separate declaration from the
basename command substitution so failures propagate explicitly, then mark
reponame readonly after the assignment succeeds.
---
Nitpick comments:
In `@test/scenarios-bootc/el10/releases/el102-y1`@el102-lrel@lvms-standard1.sh:
- Line 1: Update the shebang on line 1 of all four specified release scenario
files to use /usr/bin/bash, and do not add local shell options because
test/bin/scenario.sh already enables them.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 73c14f39-db70-4fea-8f78-898364f33be5
📒 Files selected for processing (5)
test/scenarios-bootc/el10/releases/el102-y1@el102-lrel@lvms-standard1.shtest/scenarios-bootc/el10/releases/el102-y1@el102-lrel@lvms-standard2.shtest/scenarios-bootc/el10/releases/el102@rpm-lvms-standard.shtest/scenarios-bootc/el10/releases/el98-y1@el102-lrel@lvms-standard.shtest/scenarios-bootc/el10/releases/el98-y2@el102-lrel@lvms-standard.sh
|
/test e2e-aws-tests-release |
agullon
changed the title
|
@agullon: This pull request references USHIFT-6857 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
agullon
changed the title
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-aws-tests-release |
|
/retest |
1 similar comment
|
/retest |
|
Backport to release-5.0: #7298 |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
@agullon: This pull request references USHIFT-6857 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-tests-bootc-release-el10 /test e2e-aws-tests |
|
/test e2e-aws-tests-bootc-periodic-arm-el9 |
|
/override ci/prow/e2e-aws-tests-bootc-el9 because no changes affecting those CI jobs |
|
@agullon: Overrode contexts on behalf of agullon: ci/prow/e2e-aws-tests-bootc-el9, ci/prow/e2e-aws-tests-bootc-periodic-arm-el9, ci/prow/e2e-aws-tests-bootc-periodic-el10, ci/prow/e2e-aws-tests-bootc-periodic-el9, ci/prow/e2e-aws-tests-periodic, ci/prow/e2e-aws-tests-periodic-arm DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-tests-bootc-release-el10 |
|
Scheduling tests matching the |
|
/override ci/prow/e2e-aws-tests |
|
@agullon: Overrode contexts on behalf of agullon: ci/prow/e2e-aws-tests, ci/prow/e2e-aws-tests-bootc-arm-el9, ci/prow/e2e-aws-tests-bootc-periodic-arm-el10, ci/prow/e2e-aws-tests-bootc-periodic-el9, ci/prow/e2e-aws-tests-periodic, ci/prow/e2e-aws-tests-periodic-arm DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Scheduling tests matching the |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
@agullon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
24e71a3 to
5a4a977
Compare
….21→5.0 on RHEL 10.2 Add bootc LVMS upgrade scenarios (y-1 and y-2) and an RPM upgrade scenario for RHEL 10.2. The RPM scenario validates the upgrade path then reinstalls MicroShift via install.robot to run the standard validation suites afterward. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
Add containerfile definitions for rhel102-brew-y1, rhel98-brew-y1, and rhel98-brew-y2 bootc images referenced by the new upgrade scenarios. Remove the orphaned rhel102-bootc-brew containerfile that no scenario uses and had an outdated BREW_VERSION env var guard. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
…xhaustion Release jobs on metal instances exhaust host disk when many scenarios keep their VMs up concurrently. Reduce the release upgrade/standard scenario VM disk from 30GB to 20GB so the VMs fit within the available storage. The 1Gi LVMS workload PVC leaves ample room in the ~13GB data VG that a 20GB disk provides after the 15GB root LV. Parallelism stays at -j 20: merging the standard1/standard2 release scenarios into single scenarios lowered the concurrent scenario count. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/pipeline required |
|
Scheduling tests matching the |
|
/label jira/valid-bug |
openshift-ci
Bot
added
jira/valid-bug
openshift-ci-robot
added
the
verified
|
@agullon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Summary
Adds CI release scenarios for MicroShift upgrade paths to 5.0 on RHEL 10.2, and tunes release-job resource usage so the scenarios fit on the metal CI hosts.
New upgrade scenarios (USHIFT-7285 / USHIFT-7286 / USHIFT-7287)
el102-y1@el102-lrel@rpm-standard.shel102-y1@el102-lrel@lvms-standard.shel98-y1@el102-lrel@lvms-standard.shel98-y2@el102-lrel@lvms-standard.shThe bootc scenarios create a 1Gi LVMS PVC before the upgrade and verify it survives afterward, then run the standard suites. The RPM scenario validates the upgrade path, then reinstalls MicroShift via
install.robotto run the standard validation suites.Missing bootc containerfiles (USHIFT-6857)
Adds the
rhel102-bootc-brew-y1-with-optionalcontainerfile referenced by the new el10 upgrade scenarios (renamed from the orphanedrhel102-bootc-brew.containerfile, which no scenario used and had an outdatedBREW_VERSIONenv-var guard).Release-job resource tuning
Reduces the per-scenario VM disk from 30GB to 20GB across the release upgrade/standard scenarios so many VMs fit concurrently on the metal CI hosts. The 1Gi LVMS PVC leaves ample room in the ~13GB data VG a 20GB disk provides after the 15GB root LV.
Parallelism stays at
-j 20— merging thestandard1/standard2release scenarios into single scenarios already lowered the concurrent scenario count.Test plan
🤖 Generated with Claude Code